[
https://issues.apache.org/jira/browse/HADOOP-18417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584915#comment-17584915
]
ASF GitHub Bot commented on HADOOP-18417:
-----------------------------------------
snmvaughan opened a new pull request, #4807:
URL: https://github.com/apache/hadoop/pull/4807
### Description of PR
This addresses an issue where the plugin's default classpath for executing
tests fails to include org.junit.platform.launcher.core.LauncherFactory.
It adds `failIfNoSpecifiedTests` defaulted to false, as it is breaking the
shaded client build and we are a multi module project.
if you run `mvn clean test -Dtest=TestDistributedFileSystem` this is
expected to work
### How was this patch tested?
Executed locally to replicate the original failure introduced by upgrading
the plugin:
```
mvn --batch-mode verify -fae --batch-mode -am -pl
hadoop-client-modules/hadoop-client-check-invariants -pl
hadoop-client-modules/hadoop-client-check-test-invariants -pl
hadoop-client-modules/hadoop-client-integration-tests -Dtest=NoUnitTests
-Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dspotbugs.skip=true
```
Running just a specific test across the entire project runs a single test
without failing:
```
mvn clean test -Dtest=TestDistributedFileSystem
```
Running `NoUnitTests` across the entire project runs no tests without
failing:
```
maven surefire:test -Dtest=NoUnitTests
```
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> Upgrade Maven Surefire plugin to 3.0.0-M7
> -----------------------------------------
>
> Key: HADOOP-18417
> URL: https://issues.apache.org/jira/browse/HADOOP-18417
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.4.0, 3.3.9
> Reporter: Steve Vaughan
> Assignee: Steve Vaughan
> Priority: Blocker
> Labels: pull-request-available
>
> The Maven Surefire plugin 3.0.0-M1 doesn't always include the launcher as
> part of it's setup, which can cause problems with Yarn tests. Some of the
> Yarn modules use Jupiter, which may be a complicating factor. Switching to
> 3.0.0-M7 fixes the issue.
> This is currently blocking MAPREDUCE-7386
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
