slfan1989 commented on code in PR #4908:
URL: https://github.com/apache/hadoop/pull/4908#discussion_r974839419


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java:
##########
@@ -214,6 +215,12 @@ public final class HttpServer2 implements FilterContainer {
   private StatisticsHandler statsHandler;
   private HttpServer2Metrics metrics;
 
+  private static final String MASK = "******";
+  public static final String FEDERATION_STATESTORE_SQL_USERNAME =

Review Comment:
   Thanks a lot for your suggestion,  I agree with you,  I think we should use 
separate config file configuration to store passwords and use KMS to encrypt 
passwords.  This part needs to submit a separate pr. 
   
   In this pr, when we get the configuration from the page (such as the router 
webpage), the configuration containing some keywords can be displayed in the 
form of a mask.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to