goiri commented on code in PR #4908:
URL: https://github.com/apache/hadoop/pull/4908#discussion_r975605403
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ConfServlet.java:
##########
@@ -43,6 +43,7 @@ public class ConfServlet extends HttpServlet {
protected static final String FORMAT_JSON = "json";
protected static final String FORMAT_XML = "xml";
+
Review Comment:
Avoid
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:
##########
@@ -3593,11 +3593,13 @@ public void writeXml(Writer out) throws IOException {
* </ul>
* @param propertyName xml property name.
* @param out the writer to write to.
+ * @param config configuration.
* @throws IOException raised on errors performing I/O.
*/
- public void writeXml(@Nullable String propertyName, Writer out)
+ public void writeXml(@Nullable String propertyName, Writer out,
Configuration config)
Review Comment:
We keep calling this with null, keep a version with the old signature that
passes null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
