slfan1989 commented on code in PR #4908:
URL: https://github.com/apache/hadoop/pull/4908#discussion_r974842049


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ConfServlet.java:
##########
@@ -43,13 +48,18 @@ public class ConfServlet extends HttpServlet {
   protected static final String FORMAT_JSON = "json";
   protected static final String FORMAT_XML = "xml";
 
+
   /**
    * Return the Configuration of the daemon hosting this servlet.
    * This is populated when the HttpServer starts.
    */
   private Configuration getConfFromContext() {
     Configuration conf = (Configuration)getServletContext().getAttribute(
         HttpServer2.CONF_CONTEXT_ATTRIBUTE);
+    List<String> props = new ArrayList<>();
+    props.add(FEDERATION_STATESTORE_SQL_USERNAME);

Review Comment:
   I agree with you, I will refactor part of the code to make this part of the 
ability more general.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to