Hexiaoqiao commented on PR #4945: URL: https://github.com/apache/hadoop/pull/4945#issuecomment-1261758130
> 1、When fsVolume.getVolumeMap() scan the bock from disk to add block metadata，it may add new block metadata when another thread add block. Great point. +1 from my side. So volume level lock will be more proper? > 2、How we deal conflict when remove BlockPool operating occur at same time. Not sure if this is block issue. This improvement seems not involve global meta management, only prepare phase here? So any conflict here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
