MingXiangLi commented on PR #4945: URL: https://github.com/apache/hadoop/pull/4945#issuecomment-1261780786
> Great point. +1 from my side. So volume level lock will be more proper? volume level is ok, It will hold the block pool read lock, to avoid case2 conflict occur。 > Not sure if this is block issue. This improvement seems not involve global meta management, only prepare phase here? So any conflict here? addVolume() may invoke by refresh Configuration.It may conflict by FsDatasetImpl#shutdownBlockPool.There are two stages in FsDatasetImpl#shutdownBlockPool.For example conflict will occur like this. ` FsDatasetImpl#shutdownBlockPool*volumeMap.cleanUpBlockPool(bpid); FsDatasetImpl#addVolume*fsVolume.getVolumeMap(bpid, tempVolumeMap, ramDiskReplicaTracker) FsDatasetImpl#shutdownBlockPool*volumes.removeBlockPool(bpid, blocksPerVolume); ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
