Hexiaoqiao commented on PR #4945: URL: https://github.com/apache/hadoop/pull/4945#issuecomment-1261825293
> addVolume() may invoke by refresh Configuration.It may conflict by FsDatasetImpl#shutdownBlockPool.There are two stages in FsDatasetImpl#shutdownBlockPool.For example conflict will occur like this. > > 1.FsDatasetImpl#shutdownBlockPool*volumeMap.cleanUpBlockPool > 2.FsDatasetImpl#addVolume*fsVolume.getVolumeMap > 3.FsDatasetImpl#shutdownBlockPool*volumes.removeBlockPool Got it. What I mean above is that `fsVolume.getVolumeMap(bpid, tempVolumeMap, ramDiskReplicaTracker);` is absolutely local variable operation, so is it necessary to hold lock here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
