ayushtkn commented on code in PR #5301:
URL: https://github.com/apache/hadoop/pull/5301#discussion_r1073077149
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java:
##########
@@ -901,7 +901,7 @@ public Builder setNumHandlers(int numHandlers) {
* @return Default: -1.
* @param numReaders input numReaders.
*/
- public Builder setnumReaders(int numReaders) {
+ public Builder setNumReaders(int numReaders) {
Review Comment:
Is this ok from compatibility point of view, it is a public method in a
public class. if any downstream project is using it, they will get compilation
failures?
this method seems to be there since 2012, so pretty old as well...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
