haiyang1987 commented on code in PR #5301:
URL: https://github.com/apache/hadoop/pull/5301#discussion_r1095503796
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java:
##########
@@ -901,7 +901,7 @@ public Builder setNumHandlers(int numHandlers) {
* @return Default: -1.
* @param numReaders input numReaders.
*/
- public Builder setnumReaders(int numReaders) {
+ public Builder setNumReaders(int numReaders) {
Review Comment:
Hi @tomscut @steveloughran @ayushtkn thanks help review it.
sorry for the late reply.
Considering that it is a public method in a public class and avoid
compilation failures in downstream use, can create a new method as
@steveloughran said, and keep the old method as deprecated, which may be
better.
I will update PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
