goiri commented on code in PR #5443: URL: https://github.com/apache/hadoop/pull/5443#discussion_r1122098165
########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java: ########## @@ -67,9 +67,9 @@ @InterfaceAudience.Public @InterfaceStability.Evolving -public abstract -class AbstractDelegationTokenSecretManager<TokenIdent -extends AbstractDelegationTokenIdentifier> +public abstract Review Comment: In general, this is a fairly fundamental class in Hadoop in general. I would propose to do a separate JIRA to clean this class up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
