krishan1390 commented on code in PR #5443:
URL: https://github.com/apache/hadoop/pull/5443#discussion_r1122613979
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java:
##########
@@ -419,31 +427,32 @@ public synchronized void addPersistedDelegationToken(
}
}
- /**
- * Update the current master key
- * This is called once by startThreads before tokenRemoverThread is created,
+ /**
+ * Update the current master key
+ * This is called once by startThreads before tokenRemoverThread is created,
* and only by tokenRemoverThread afterwards.
*/
- private void updateCurrentKey() throws IOException {
+ protected void updateCurrentKey() throws IOException {
LOG.info("Updating the current master key for generating delegation
tokens");
/* Create a new currentKey with an estimated expiry date. */
int newCurrentId;
synchronized (this) {
- newCurrentId = incrementCurrentKeyId();
+ newCurrentId = generateNewKeyId();
Review Comment:
the actual requirement is to generate new keys and not to increment keys -
this greatly simplifies implementation for various DB systems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
