krishan1390 commented on code in PR #5443: URL: https://github.com/apache/hadoop/pull/5443#discussion_r1122613543
########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java: ########## @@ -67,9 +67,9 @@ @InterfaceAudience.Public @InterfaceStability.Evolving -public abstract -class AbstractDelegationTokenSecretManager<TokenIdent -extends AbstractDelegationTokenIdentifier> +public abstract Review Comment: I don't think any of these changes will affect any other functionality in any sub class - I verified the same . And the changes are either very generic like encapsulation, exception handling, concurrency handling, etc - let me know if this still warrants a seperate JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
