virajjasani commented on PR #5445: URL: https://github.com/apache/hadoop/pull/5445#issuecomment-1451077691
> If my intent is just for processQueueMessages, I will expose and just shoot that directly, rather than doing the whole loop. That would also work but as part of the test, we might rather want to wait for source code to do that so that if something changes in source code sequence or so, our test would be able to catch it (if the intention of the test is to wait for processQueueMessages to be successfully called and completed by source code). > Changing the existing uses with this would be slowing down tests, which are already above tolerable limits. For this PR, only `testReportBadBlocks` test is updated to use it, but anyways nothing wrong with waiting for sometime and circling back to this when/if required. Thanks Ayush :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
