saxenapranav commented on code in PR #5445:
URL: https://github.com/apache/hadoop/pull/5445#discussion_r1123444698


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ErrorReportAction.java:
##########
@@ -34,7 +34,8 @@ public class ErrorReportAction implements 
BPServiceActorAction {
 
   final int errorCode;
   final String errorMessage;
-  
+  private boolean isReportSuccessfullySent = false;

Review Comment:
   Would volatile boolean be better? Reason being, isReportSuccessfullySent 
might be called by some other thread.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to