ayushtkn commented on PR #5445: URL: https://github.com/apache/hadoop/pull/5445#issuecomment-1451100991
Playing a bit more with it: Single sleep doesn't repro itself. My wild guess is, it isn't testing from where we started. It is inducing a race by **nextHeartbeatTime**, that too because we induced sleeps, else like very tough with the kind of code we have now. > we might rather want to wait for source code to do that so that if something changes in source code sequence or so, our test would be able to catch it not the intention of the original test, it is just waiting for the message in the Queue to be sent and processed and checking the response of namenode to that, or if namenode acknowledges that or not. (I still feel we could have invoked **processQueueMessages** directly and saved some time, but lets see, the present code is also working) If someone removes the processQueueMessages itself from the **sendHeartbeat**, then also this test should fail or atleast some should, rest we can't guarantee everything... >but anyways nothing wrong with waiting for sometime and circling back to this when/if required. yeps, lets wait and see if any failures and circle back in future and see what are the potential solutions then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
