virajjasani commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1454074972

   > The path was unique earlier
   > 
   > ```
   >   static final String AUDITLOG_FILE =
   >       GenericTestUtils.getTempPath("TestFsck-audit.log");
   > ```
   
   That's because the previous version was using dynamically added appenders 
and disregarding the actual appenders set in log4j properties, this was a hack 
and it would not work with log4j2. Hence we changed that with previous PR. Now 
the tests share the same file location for the audit log, because it's the 
log4j properties that all tests share.
   
   We can make a new custom log4j properties and reload it dynamically, that's 
an option but again it would be another hack because in log4j2, while this is 
allowed, the APIs are not public and can break compatibilities.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to