virajjasani commented on PR #5451: URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1454082092
Here is the most imp distinguisher for tests before and after PR #5418 : Before patch: The tests were deciding which log file to use and also disabling async appender soon after the expected logs were in. Hence, the tests can match the expected regex. This is hack because overriding log4j properties is not compatible across log4j versions. After patch: The tests share the same log file for audit log and no longer applies hack of changing the log file dynamically and stopping appenders when needed etc. Hence, now the tests are made to search for regex only for "specific file operations" because audit logs will have operations for other tests as well. We no longer have any hacks here that log4j2 does not support (or recommend doing). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
