virajjasani commented on PR #5451: URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1454160995
Also, FWIW, in this particular revision, I also removed the file delete operation from TestAuditLogs too because deleting the file is no longer needed as all tests share the same file. https://github.com/apache/hadoop/pull/5418/commits/bace0390b7e9f224232f943e7f40da08bbbe5f37 What we can do to ensure avoiding collision is keep all audit log specific tests to one test file only, for instance TestAuditLogs. It would ensure file is cleaned up before starting the test and it will do it's own duty to check and verify if all necessary regex patterns are matching. TestFsck has only 3 tests that need to validate regex of audit logs, so we can move them to TestAuditLogs and check for fsck specific audit log regex too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
