[ 
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696625#comment-17696625
 ] 

ASF GitHub Bot commented on HADOOP-18631:
-----------------------------------------

ayushtkn commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455210420

   If it doesn’t then we are good. But should change the other test as well to 
use this, rather than the file logic, that if someone copies that for a new 
test or so, he doesn’t leads us to a mess, and be consistent on the approach 
   
   -> I haven’t tested myself yet, would spare some time to double check in 
some time (on vacation now)




> Migrate Async appenders to log4j properties
> -------------------------------------------
>
>                 Key: HADOOP-18631
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18631
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.0
>
>
> Before we can upgrade to log4j2, we need to migrate async appenders that we 
> add "dynamically in the code" to the log4j.properties file. Instead of using 
> core/hdfs site configs, log4j properties or system properties should be used 
> to determine if the given logger should use async appender.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to