[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696540#comment-17696540
]
ASF GitHub Bot commented on HADOOP-18631:
-----------------------------------------
virajjasani commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455029246
> And one more to try if I delete the file while using appender, will the
test using appender fail?
The test using it's own appender (i.e. new LogCapturer instance) would not
fail.
Just to quickly repro this, I deleted file in the middle of running tests in
TestAuditLogs and made sure that some tests in TestAuditLogs do fail because of
this and at the same time ran TestFsck simultaneously and the tests that rely
on reading audit logs did pass without any issues. I verified the log lines too
to ensure the tests in TestFsck had sufficient audit logs captured at regular
intervals, after TestAuditLogs deleted the file.
Thanks for the above ideas
> Migrate Async appenders to log4j properties
> -------------------------------------------
>
> Key: HADOOP-18631
> URL: https://issues.apache.org/jira/browse/HADOOP-18631
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> Before we can upgrade to log4j2, we need to migrate async appenders that we
> add "dynamically in the code" to the log4j.properties file. Instead of using
> core/hdfs site configs, log4j properties or system properties should be used
> to determine if the given logger should use async appender.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
