[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696602#comment-17696602
]
ASF GitHub Bot commented on HADOOP-18631:
-----------------------------------------
virajjasani commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455158738
For that to happen, all tests (the entire test class I mean) should also use
stop capturing of appender (which internally removes the appender). I just did
that in recent commit to set an example but it seems not all tests are
following this.
While it's not that much of a big deal IMO as tests are supposed to extract
the specific content that they are interested in but leaving appenders behind
(without removing them i.e. without doing cleanup) will just keep adding more
and more logs getting written to more string buffers.
I can do this cleanup for other tests in a separate sub-task if you are
fine. Please let me know.
> Migrate Async appenders to log4j properties
> -------------------------------------------
>
> Key: HADOOP-18631
> URL: https://issues.apache.org/jira/browse/HADOOP-18631
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> Before we can upgrade to log4j2, we need to migrate async appenders that we
> add "dynamically in the code" to the log4j.properties file. Instead of using
> core/hdfs site configs, log4j properties or system properties should be used
> to determine if the given logger should use async appender.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
