[
https://issues.apache.org/jira/browse/HADOOP-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702818#comment-17702818
]
ASF GitHub Bot commented on HADOOP-18565:
-----------------------------------------
ahmarsuhail commented on code in PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#discussion_r1142323639
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java:
##########
@@ -807,10 +742,8 @@ private static AWSCredentialsProvider
createAWSV1CredentialProvider(
* @return the instantiated class
* @throws IOException on any instantiation failure.
*/
- private static AwsCredentialsProvider createAWSV2CredentialProvider(
- Configuration conf,
- Class<?> credClass,
- @Nullable URI uri) throws IOException {
+ private static AwsCredentialsProvider
createAWSV2CredentialProvider(Configuration conf,
Review Comment:
have moved all of this to new class `AwsCredentialListProvider`. not too
sure about the name, happy to change. Also was wondering if all the reflection
code (`getInstanceFromReflection()`) in S3AUtils should be moved out too, to
this `AwsCredentialListProvider` or maybe another new class in `s3a.auth` ?
Didn't move out currently as it's also used by the SignerFactory
> AWS SDK V2 - Complete outstanding items
> ---------------------------------------
>
> Key: HADOOP-18565
> URL: https://issues.apache.org/jira/browse/HADOOP-18565
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Ahmar Suhail
> Priority: Major
> Labels: pull-request-available
>
> The following work remains to complete the SDK upgrade work:
> * S3A allows users configure to custom signers, add in support for this.
> * Remove SDK V1 bundle dependency
> * Update `getRegion()` logic to use retries.
> * Add in progress listeners for `S3ABlockOutputStream`
> * Fix any failing tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
