ayushtkn commented on code in PR #5554:
URL: https://github.com/apache/hadoop/pull/5554#discussion_r1165906468
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java:
##########
@@ -140,7 +143,7 @@ private void printUsage(String cmd) {
private String getUsage(String cmd) {
if (cmd == null) {
String[] commands =
- {"-add", "-update", "-rm", "-ls", "-getDestination", "-setQuota",
+ {"-add", "-addall", "-update", "-rm", "-ls", "-getDestination",
"-setQuota",
Review Comment:
Why don’t we adjust it in add only? Why we need a new command?
just make add take multiple entries rather than 1? If there are more than
one entries, your code, else the present one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]