ayushtkn commented on code in PR #5554:
URL: https://github.com/apache/hadoop/pull/5554#discussion_r1165932788
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java:
##########
@@ -140,7 +143,7 @@ private void printUsage(String cmd) {
private String getUsage(String cmd) {
if (cmd == null) {
String[] commands =
- {"-add", "-update", "-rm", "-ls", "-getDestination", "-setQuota",
+ {"-add", "-addall", "-update", "-rm", "-ls", "-getDestination",
"-setQuota",
Review Comment:
Nopes, compat won't break, adding extra options is allowed, Unless existing
add command works as is, like doesn't change in behaviour, we are good from
compat point of view.
Even **mkdir** behaves in similar way
```
bash-4.2$ hdfs dfs -mkdir /dir /dir1 /dir2 /dir3 /dir4
bash-4.2$ hdfs dfs -ls /
Found 5 items
drwxr-xr-x - hadoop supergroup 0 2023-04-13 19:08 /dir
drwxr-xr-x - hadoop supergroup 0 2023-04-13 19:08 /dir1
drwxr-xr-x - hadoop supergroup 0 2023-04-13 19:08 /dir2
drwxr-xr-x - hadoop supergroup 0 2023-04-13 19:08 /dir3
drwxr-xr-x - hadoop supergroup 0 2023-04-13 19:08 /dir4
```
It can take multiple entries, so we can do for -add as well. Juzz my
thoughts, if @goiri is good with a new command, consider no objections from me
as well :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
