virajjasani commented on code in PR #5554:
URL: https://github.com/apache/hadoop/pull/5554#discussion_r1165913930
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java:
##########
@@ -140,7 +143,7 @@ private void printUsage(String cmd) {
private String getUsage(String cmd) {
if (cmd == null) {
String[] commands =
- {"-add", "-update", "-rm", "-ls", "-getDestination", "-setQuota",
+ {"-add", "-addall", "-update", "-rm", "-ls", "-getDestination",
"-setQuota",
Review Comment:
I think it sort of breaks compatibility for `-add` no? also, by keeping
separate command like `-addall`, we are able to clearly express that we can add
more mount points with it, so it is better and clean separation?
Compatibility might not be completely broken as such but if we think from
the viewpoint that earlier if we added multiple entries, then command would
have failed right away and now with this change, it would be able to add
multiple entries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
