Hexiaoqiao commented on code in PR #5691:
URL: https://github.com/apache/hadoop/pull/5691#discussion_r1206599971
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RBFConfigKeys.java:
##########
@@ -115,6 +115,12 @@ public class RBFConfigKeys extends
CommonConfigurationKeysPublic {
FEDERATION_ROUTER_PREFIX + "heartbeat-state.interval";
public static final long DFS_ROUTER_HEARTBEAT_STATE_INTERVAL_MS_DEFAULT =
TimeUnit.SECONDS.toMillis(5);
+ public static final String DFS_ROUTER_NAMENODE_HEARTBEAT_JMX_ENABLED =
Review Comment:
Please add these new configuration items to hdfs-rbf-default.xml.
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java:
##########
@@ -107,6 +112,17 @@ public class NamenodeHeartbeatService extends
PeriodicService {
/** URL scheme to use for JMX calls. */
private String scheme;
+ /** Whether to update JMX report */
Review Comment:
checkstyle as Yetus said.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
