mkuchenbecker commented on code in PR #5691:
URL: https://github.com/apache/hadoop/pull/5691#discussion_r1207150754


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java:
##########
@@ -107,6 +110,15 @@ public class NamenodeHeartbeatService extends 
PeriodicService {
   /** URL scheme to use for JMX calls. */
   private String scheme;
 
+  /** Frequency of updates to JMX report. */
+  private long updateJmxIntervalMs;
+  /** Timestamp of last attempt to update JMX report. */
+  private long lastJmxUpdateAttempt;

Review Comment:
   Should we be getting a glob of FSNamesystem metrics as compared to querying 
the specific metrics needed?
   
   I.e. this queries `FSNamesystem*`, and not all those metrics are eneded or 
used. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to