brumi1024 commented on code in PR #5784:
URL: https://github.com/apache/hadoop/pull/5784#discussion_r1266612668
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppRunningOnNodeEvent.java:
##########
@@ -23,13 +23,23 @@
public class RMAppRunningOnNodeEvent extends RMAppEvent {
private final NodeId node;
+ private final boolean inAcquiredState;
Review Comment:
Nit: since the key here is that this container is transitioning from
ACQUIRED directly to RELEASED I think Adam's fromAcquired variable naming was
more descriptive.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java:
##########
@@ -1088,8 +1088,14 @@ public void transition(RMAppImpl app, RMAppEvent event) {
// otherwise, add it to ranNodes for further process
app.ranNodes.add(nodeAddedEvent.getNodeId());
- app.logAggregation.addReportIfNecessary(
- nodeAddedEvent.getNodeId(), app.getApplicationId());
+ if (!nodeAddedEvent.isInAcquiredState()) {
+ app.logAggregation.addReportIfNecessary(
+ nodeAddedEvent.getNodeId(), app.getApplicationId());
+ } else {
+ LOG.warn(String.format("Not considering container for log aggregation "
+ + "while it is in an ACQUIRED state for nodeId: %s and appId:
%s",
+ nodeAddedEvent.getNodeId(), app.getApplicationId()));
Review Comment:
Same here as below, the key here is that the app is currently transitioning
from ACQUIRED directly to RELEASED, hence the warning message is a bit
misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
