brumi1024 commented on code in PR #5784:
URL: https://github.com/apache/hadoop/pull/5784#discussion_r1266850170
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppRunningOnNodeEvent.java:
##########
@@ -23,13 +23,23 @@
public class RMAppRunningOnNodeEvent extends RMAppEvent {
private final NodeId node;
+ private final boolean inAcquiredState;
Review Comment:
You're right, I misunderstood it based on the description of the ticket, and
missed that we actually call this from AcquiredTransition.
However I still think the name is misleading, as RMAppRunningOnNodeEvent is
an event, it can't be in Acquired state, this field is basically telling us if
the event was created from the Acquired state transition (which I guess was
Adam's intention with the first naming). So I think the name of
containerInAcquiredState or createdFromAcquiredState/fromAcquiredState would be
better suited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
