brumi1024 commented on code in PR #5784:
URL: https://github.com/apache/hadoop/pull/5784#discussion_r1266889475
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppRunningOnNodeEvent.java:
##########
@@ -23,13 +23,23 @@
public class RMAppRunningOnNodeEvent extends RMAppEvent {
private final NodeId node;
+ private final boolean inAcquiredState;
Review Comment:
The only thing is I'm not sure if we should introduce the container concept
here, as it's mostly irrelevant to the event itself (and its other uses). Hence
I think the latter is a bit more self-explanatory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
