[
https://issues.apache.org/jira/browse/HADOOP-18870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760778#comment-17760778
]
ASF GitHub Bot commented on HADOOP-18870:
-----------------------------------------
ferdelyi opened a new pull request, #6007:
URL: https://github.com/apache/hadoop/pull/6007
…DOOP-18139 and HADOOP-18709
With this fix the HadoopZookeeperFactory's newZooKeeper method override is
taking effect again.
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
Curator change caused the newZooKeeper 4-parameter method-override to be
inactive. Fixed it by routing it to a 5-parameter method-override and keeping
the original functionality intact.
### How was this patch tested?
With unit a test and a local integration test.
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> CURATOR-599 change broke functionality introduced in HADOOP-18139 and
> HADOOP-18709
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-18870
> URL: https://issues.apache.org/jira/browse/HADOOP-18870
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Affects Versions: 3.4.0, 3.3.5
> Reporter: Ferenc Erdelyi
> Assignee: Ferenc Erdelyi
> Priority: Major
>
> [Curator PR#391
> |https://github.com/apache/curator/pull/391/files#diff-687a4ed1252bfb4f56b3aeeb28bee4413b7df9bec4b969b72215587158ac875dR59]
> introduced a default method in the ZooKeeperFactory interface, hence the
> override of the 4-parameter NewZookeeper method in the HadoopZookeeperFactory
> class is not taking effect due to this.
> Proposing routing the 4-parameter method to a 5-parameter method, which
> instantiates the ZKConfiguration as the 5th parameter. This is a non-breaking
> change, as the ZKConfiguration is currently instantiated within the method.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
