[
https://issues.apache.org/jira/browse/HADOOP-18870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762534#comment-17762534
]
Szilard Nemeth commented on HADOOP-18870:
-----------------------------------------
[~bender]
{quote}
Proposing routing the 4-parameter method to a 5-parameter method, which
instantiates the ZKConfiguration as the 5th parameter. This is a non-breaking
change, as the ZKConfiguration is currently instantiated within the method.
{quote}
Am I missing something or you meant `ZKClientConfig` as the 5th parameter,
right?
Checking the linked Curator PR
(https://github.com/apache/curator/pull/391/files#diff-687a4ed1252bfb4f56b3aeeb28bee4413b7df9bec4b969b72215587158ac875dR59)
shows me ZKClientConfig as the 5th parameter there.
Can you fix the description of the jira ?
> CURATOR-599 change broke functionality introduced in HADOOP-18139 and
> HADOOP-18709
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-18870
> URL: https://issues.apache.org/jira/browse/HADOOP-18870
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Affects Versions: 3.4.0, 3.3.5
> Reporter: Ferenc Erdelyi
> Assignee: Ferenc Erdelyi
> Priority: Major
> Labels: pull-request-available
>
> [Curator PR#391
> |https://github.com/apache/curator/pull/391/files#diff-687a4ed1252bfb4f56b3aeeb28bee4413b7df9bec4b969b72215587158ac875dR59]
> introduced a default method in the ZooKeeperFactory interface, hence the
> override of the 4-parameter NewZookeeper method in the HadoopZookeeperFactory
> class is not taking effect due to this.
> Proposing routing the 4-parameter method to a 5-parameter method, which
> instantiates the ZKConfiguration as the 5th parameter. This is a non-breaking
> change, as the ZKConfiguration is currently instantiated within the method.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
