[
https://issues.apache.org/jira/browse/HADOOP-18870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760790#comment-17760790
]
ASF GitHub Bot commented on HADOOP-18870:
-----------------------------------------
K0K0V0K commented on code in PR #6007:
URL: https://github.com/apache/hadoop/pull/6007#discussion_r1311307807
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/curator/TestZKCuratorManager.java:
##########
@@ -205,4 +210,35 @@ private void validateJaasConfiguration(String
clientConfig, String principal, St
assertEquals("Validate that expected keytab is set in Jaas config", keytab,
entries[0].getOptions().get("keyTab"));
}
+
+ @Test
+ public void testNewZooKeeperOverride() throws Exception{
Review Comment:
Usually in Java we prefer to order methods like public -> protected ->
private.
So this should be at top of validateJaasConfiguration method.
https://www.oracle.com/java/technologies/javase/codeconventions-fileorganization.html
Also i dont think this is the best test name, cause we dont actually test
that method.
Maybe testCuratorFrameworkFactory would be better.
> CURATOR-599 change broke functionality introduced in HADOOP-18139 and
> HADOOP-18709
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-18870
> URL: https://issues.apache.org/jira/browse/HADOOP-18870
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Affects Versions: 3.4.0, 3.3.5
> Reporter: Ferenc Erdelyi
> Assignee: Ferenc Erdelyi
> Priority: Major
> Labels: pull-request-available
>
> [Curator PR#391
> |https://github.com/apache/curator/pull/391/files#diff-687a4ed1252bfb4f56b3aeeb28bee4413b7df9bec4b969b72215587158ac875dR59]
> introduced a default method in the ZooKeeperFactory interface, hence the
> override of the 4-parameter NewZookeeper method in the HadoopZookeeperFactory
> class is not taking effect due to this.
> Proposing routing the 4-parameter method to a 5-parameter method, which
> instantiates the ZKConfiguration as the 5th parameter. This is a non-breaking
> change, as the ZKConfiguration is currently instantiated within the method.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
