goiri commented on code in PR #6012:
URL: https://github.com/apache/hadoop/pull/6012#discussion_r1311983523
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator/src/main/java/org/apache/hadoop/yarn/server/globalpolicygenerator/GlobalPolicyGenerator.java:
##########
@@ -290,7 +291,9 @@ private String getHostName(Configuration config)
public static void main(String[] argv) {
try {
- startGPG(argv, new YarnConfiguration());
+ YarnConfiguration conf = new YarnConfiguration();
+ new GenericOptionsParser(conf, argv);
Review Comment:
I'm not familiar with this but this use looks not complete.
Most other places use the getRemainingArgs().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
