goiri commented on code in PR #6012:
URL: https://github.com/apache/hadoop/pull/6012#discussion_r1316558450
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/Router.java:
##########
@@ -245,18 +247,26 @@ public static void main(String[] argv) {
StringUtils.startupShutdownMessage(Router.class, argv, LOG);
Router router = new Router();
try {
-
- // Remove the old hook if we are rebooting.
- if (null != routerShutdownHook) {
- ShutdownHookManager.get().removeShutdownHook(routerShutdownHook);
+ GenericOptionsParser hParser = new GenericOptionsParser(conf, argv);
+ argv = hParser.getRemainingArgs();
+ if (argv.length > 1) {
+ if (argv[0].equals("-format-state-store")) {
+ // TODO: YARN-11548. [Federation] Router Supports Format
FederationStateStore.
Review Comment:
All these things should output an error at least.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator/src/main/java/org/apache/hadoop/yarn/server/globalpolicygenerator/GlobalPolicyGenerator.java:
##########
@@ -290,7 +292,18 @@ private String getHostName(Configuration config)
public static void main(String[] argv) {
try {
- startGPG(argv, new YarnConfiguration());
+ YarnConfiguration conf = new YarnConfiguration();
+ GenericOptionsParser hParser = new GenericOptionsParser(conf, argv);
+ argv = hParser.getRemainingArgs();
+ if (argv.length > 1) {
+ if (argv[0].equals("-format-policy-store")) {
+ // TODO: YARN-11561. [Federation] GPG Supports Format
PolicyStateStore.
Review Comment:
Should this at least report something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
