slfan1989 commented on code in PR #6012:
URL: https://github.com/apache/hadoop/pull/6012#discussion_r1312383736
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator/src/main/java/org/apache/hadoop/yarn/server/globalpolicygenerator/GlobalPolicyGenerator.java:
##########
@@ -290,7 +291,9 @@ private String getHostName(Configuration config)
public static void main(String[] argv) {
try {
- startGPG(argv, new YarnConfiguration());
+ YarnConfiguration conf = new YarnConfiguration();
+ new GenericOptionsParser(conf, argv);
Review Comment:
Thank you very much for helping review the code! When I first saw
`YARN-11433`, my thoughts were aligned with yours, and I also had concerns
about whether such an implementation was necessary.
I noticed `YARN-3255, where RM, NM, JobHistoryServer, and
WebAppProxyServer's main() should support generic options.` Other components
in YARN, such as `RM`, `NM`, and `JobHistoryServer`, have implemented similar
logic. I believe `Router` and `GPG` should be able to implement this logic as
well.
https://github.com/apache/hadoop/blob/b6d06c89282153a0b5607e6c1236e4138669a1d9/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java#L1051-L1058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
