steveloughran commented on code in PR #6006:
URL: https://github.com/apache/hadoop/pull/6006#discussion_r1326267233
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/magic/ITestMagicCommitProtocol.java:
##########
@@ -94,11 +95,11 @@ public MagicS3GuardCommitter createFailingCommitter(
}
protected void validateTaskAttemptPathDuringWrite(Path p,
- final long expectedLength) throws IOException {
+ final long expectedLength, String jobId) throws IOException {
String pathStr = p.toString();
Assertions.assertThat(pathStr)
.describedAs("Magic path")
- .contains(MAGIC);
+ .contains(MAGIC_PATH_PREFIX + jobId);
Review Comment:
we should really look for / at both ends of this string, for strictness,
shouldn't we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
