shameersss1 commented on PR #6006: URL: https://github.com/apache/hadoop/pull/6006#issuecomment-1720570877
> So one aspect of this change is that __magic on its own is no longer valid. I think I might still like it as "Magic "even if our own committer do not use it any more. That is in case something is, not that they should except in bizarre test ways. But: if this makes the code too complicated then I'm not over worried. We aren't ever going to get into the condition where I an older version of the committee is trying to write through this version of the file system, because they are all bundled in the same jar. > > Now, some bad news: the docs are going to need to be updated as well. I think in the committer architecture doc we should actually add a paragraph on supporting parallel commit to discuss why this was needed and what are the change was. But the various strings there and those in doc comments needs to be changed. > > Maybe the thing to do is use "Magic Path" in capitals and define it in the architect a document as "path where the filesystem knows to remap paths". So rather than update the various __magic references in source docs with the new prefix, just change to "Magic Path". Gives us the option of easier maintenance in future, if ever needed (hopefully not). Ack. +1 on the doc changes as well! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
