steveloughran commented on code in PR #6006:
URL: https://github.com/apache/hadoop/pull/6006#discussion_r1329969310
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/impl/CommitUtilsWithMR.java:
##########
@@ -49,10 +50,11 @@ private CommitUtilsWithMR() {
/**
* Get the location of magic job attempts.
* @param out the base output directory.
+ * @param jobUUID unique Job ID.
* @return the location of magic job attempts.
*/
- public static Path getMagicJobAttemptsPath(Path out) {
- return new Path(out, MAGIC);
+ public static Path getMagicJobAttemptsPath(Path out, String jobUUID) {
+ return new Path(out, MAGIC_PATH_PREFIX + jobUUID);
Review Comment:
let's add a Precondition to check that the uuid isn't null/empty. I know
it's unlikely, but if something goes very wrong then duplicate paths get in
```java
Preconditions.checkArgument(jobUUID != null && !(jobUUID.isEmpty()),
"Invalid job ID: %s", jobUUID);
```
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/committer_architecture.md:
##########
@@ -1694,7 +1694,7 @@ must be used, which means: the V2 classes.
**Magic Committer: Name of directory**
Review Comment:
replace with
```
**Magic Committer: Directory Naming**
```
to reflect changes in text
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/committer_architecture.md:
##########
@@ -1694,7 +1694,7 @@ must be used, which means: the V2 classes.
**Magic Committer: Name of directory**
-The design proposes the name `__magic` for the directory. HDFS and
+The design proposes the name ``"MAGIC PATH"`` for the directory. HDFS and
Review Comment:
change this to
```
proposes the prefix "__magic_job-" as the prefix for the magic paths of
different jobs.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
