goiri commented on code in PR #6215:
URL: https://github.com/apache/hadoop/pull/6215#discussion_r1369245079
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/jobhistory/TestHistoryViewerPrinter.java:
##########
@@ -160,6 +161,14 @@ public void testHumanPrinter() throws Exception {
LINE_SEPARATOR, outStr);
}
+ public static boolean compareStrings(String str1, String str2) {
+ String[] lines1 = str1.trim().split("\n");
+ String[] lines2 = str2.trim().split("\n");
+ Arrays.sort(lines1);
+ Arrays.sort(lines2);
+ return Arrays.equals(lines1, lines2);
Review Comment:
You don't use the output.
You maye want to call it something closer to assert and also do a final:
```
assertEquals(lines1, lines2)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
