goiri commented on code in PR #6215:
URL: https://github.com/apache/hadoop/pull/6215#discussion_r1373775771
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/jobhistory/TestHistoryViewerPrinter.java:
##########
@@ -160,6 +162,10 @@ public void testHumanPrinter() throws Exception {
LINE_SEPARATOR, outStr);
}
+ private void compareStrings(String str1, String str2) {
+
Assertions.assertThat(Arrays.asList(str1.trim().split("\n"))).containsExactlyInAnyOrderElementsOf(Arrays.asList(str2.trim().split("\n")));
Review Comment:
* This could be made a little more readable by extracting the two chunks.
* Make the strings final.
* Name the method something like assertEqualLines().
* Make method static.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
