kavvya97 commented on PR #6215:
URL: https://github.com/apache/hadoop/pull/6215#issuecomment-1780365855
> You are not checking the return value of `compareStrings`, so even if it
returns `false`, I believe your test will pass. btw. rather than sort & then
array equals and then asserting true/false, did you explore something like
>
> ```
> public static void compareStrings(String str1, String str2) {
>
Assertions.assertThat(str1.split("\n")).containsExactlyInAnyOrder(str2.split("\n"));
> }
> ```
we have incorporated the above changes in the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
