[
https://issues.apache.org/jira/browse/HADOOP-19038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806289#comment-17806289
]
ASF GitHub Bot commented on HADOOP-19038:
-----------------------------------------
slfan1989 opened a new pull request, #6448:
URL: https://github.com/apache/hadoop/pull/6448
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
JIRA: HADOOP-19038. Improve create-release RUN script.
Using `create-release` will create a docker image locally, but three of the
RUN scripts may fail to execute.
1. RUN groupadd --non-unique -g 0 root
```
=> ERROR [16/20] RUN groupadd --non-unique -g 0 root
0.2s
------
> [16/20] RUN groupadd --non-unique -g 0 root:
0.154 groupadd: group 'root' already exists
------
Dockerfile:100
--------------------
98 |
99 | LABEL org.apache.hadoop.create-release="cr-19697"
100 | >>> RUN groupadd --non-unique -g 0 root
101 | RUN useradd -g 0 -u 0 -m root
102 | RUN chown -R root /home/root
```
2. RUN useradd -g 0 -u 0 -m root
```
> [17/20] RUN useradd -g 0 -u 0 -m root:
0.165 useradd: user 'root' already exists
------
Dockerfile:101
--------------------
99 | LABEL org.apache.hadoop.create-release="cr-12068"
100 | RUN groupadd --non-unique -g 0 root; exit 0;
101 | >>> RUN useradd -g 0 -u 0 -m root
102 | RUN chown -R root /home/root
103 | ENV HOME /home/root
```
3. RUN chown -R root /home/root
```
> [18/20] RUN chown -R root /home/root:
0.168 chown: cannot access '/home/root': No such file or directory
------
Dockerfile:102
--------------------
100 | RUN groupadd --non-unique -g 0 root; exit 0;
101 | RUN useradd -g 0 -u 0 -m root; exit 0;
102 | >>> RUN chown -R root /home/root
103 | ENV HOME /home/root
104 | RUN mkdir -p /maven
--------------------
```
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> Improve create-release RUN script
> ---------------------------------
>
> Key: HADOOP-19038
> URL: https://issues.apache.org/jira/browse/HADOOP-19038
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
>
> Using create-release will create a docker image locally, but three of the RUN
> scripts may fail to execute.
> 1. RUN groupadd --non-unique -g 0 root
> {code:java}
> => ERROR [16/20] RUN groupadd --non-unique -g 0 root
> 0.2s
> ------
> > [16/20] RUN groupadd --non-unique -g 0 root:
> 0.154 groupadd: group 'root' already exists
> ------
> Dockerfile:100
> --------------------
> 98 |
> 99 | LABEL org.apache.hadoop.create-release="cr-19697"
> 100 | >>> RUN groupadd --non-unique -g 0 root
> 101 | RUN useradd -g 0 -u 0 -m root
> 102 | RUN chown -R root /home/root
> {code}
> 2. RUN useradd -g 0 -u 0 -m root
> {code:java}
> > [17/20] RUN useradd -g 0 -u 0 -m root:
> 0.165 useradd: user 'root' already exists
> ------
> Dockerfile:101
> --------------------
> 99 | LABEL org.apache.hadoop.create-release="cr-12068"
> 100 | RUN groupadd --non-unique -g 0 root; exit 0;
> 101 | >>> RUN useradd -g 0 -u 0 -m root
> 102 | RUN chown -R root /home/root
> 103 | ENV HOME /home/root
> {code}
> 3. RUN chown -R root /home/root
> {code:java}
> > [18/20] RUN chown -R root /home/root:
> 0.168 chown: cannot access '/home/root': No such file or directory
> ------
> Dockerfile:102
> --------------------
> 100 | RUN groupadd --non-unique -g 0 root; exit 0;
> 101 | RUN useradd -g 0 -u 0 -m root; exit 0;
> 102 | >>> RUN chown -R root /home/root
> 103 | ENV HOME /home/root
> 104 | RUN mkdir -p /maven
> --------------------
> {code}
> Even if these three scripts fail, subsequent steps can continue to be
> executed, so I added exit 0 after the script.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
