[
https://issues.apache.org/jira/browse/HADOOP-19038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807282#comment-17807282
]
ASF GitHub Bot commented on HADOOP-19038:
-----------------------------------------
slfan1989 commented on code in PR #6448:
URL: https://github.com/apache/hadoop/pull/6448#discussion_r1453537205
##########
dev-support/bin/create-release:
##########
@@ -504,9 +504,9 @@ function dockermode
echo "LABEL org.apache.hadoop.create-release=\"cr-${RANDOM}\""
# setup ownerships, etc
- echo "RUN groupadd --non-unique -g ${group_id} ${user_name}"
- echo "RUN useradd -g ${group_id} -u ${user_id} -m ${user_name}"
- echo "RUN chown -R ${user_name} /home/${user_name}"
+ echo "RUN groupadd --non-unique -g ${group_id} ${user_name}; exit 0;"
Review Comment:
Thank you for reviewing this PR! Once an error occurs in the RUN script, the
image building process is terminated. The error I encountered does not block
the overall compilation process, so I added "exit 0". I hope that even if there
is an error, the subsequent compilation process can continue.
> Improve create-release RUN script
> ---------------------------------
>
> Key: HADOOP-19038
> URL: https://issues.apache.org/jira/browse/HADOOP-19038
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.4.0, 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> Using create-release will create a docker image locally, but three of the RUN
> scripts may fail to execute.
> 1. RUN groupadd --non-unique -g 0 root
> {code:java}
> => ERROR [16/20] RUN groupadd --non-unique -g 0 root
> 0.2s
> ------
> > [16/20] RUN groupadd --non-unique -g 0 root:
> 0.154 groupadd: group 'root' already exists
> ------
> Dockerfile:100
> --------------------
> 98 |
> 99 | LABEL org.apache.hadoop.create-release="cr-19697"
> 100 | >>> RUN groupadd --non-unique -g 0 root
> 101 | RUN useradd -g 0 -u 0 -m root
> 102 | RUN chown -R root /home/root
> {code}
> 2. RUN useradd -g 0 -u 0 -m root
> {code:java}
> > [17/20] RUN useradd -g 0 -u 0 -m root:
> 0.165 useradd: user 'root' already exists
> ------
> Dockerfile:101
> --------------------
> 99 | LABEL org.apache.hadoop.create-release="cr-12068"
> 100 | RUN groupadd --non-unique -g 0 root; exit 0;
> 101 | >>> RUN useradd -g 0 -u 0 -m root
> 102 | RUN chown -R root /home/root
> 103 | ENV HOME /home/root
> {code}
> 3. RUN chown -R root /home/root
> {code:java}
> > [18/20] RUN chown -R root /home/root:
> 0.168 chown: cannot access '/home/root': No such file or directory
> ------
> Dockerfile:102
> --------------------
> 100 | RUN groupadd --non-unique -g 0 root; exit 0;
> 101 | RUN useradd -g 0 -u 0 -m root; exit 0;
> 102 | >>> RUN chown -R root /home/root
> 103 | ENV HOME /home/root
> 104 | RUN mkdir -p /maven
> --------------------
> {code}
> Even if these three scripts fail, subsequent steps can continue to be
> executed, so I added exit 0 after the script.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
