[ 
https://issues.apache.org/jira/browse/HADOOP-19038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806304#comment-17806304
 ] 

ASF GitHub Bot commented on HADOOP-19038:
-----------------------------------------

hadoop-yetus commented on PR #6448:
URL: https://github.com/apache/hadoop/pull/6448#issuecomment-1890483348

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |  18m  0s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  shelldocs  |   0m  0s |  |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   |||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  14m  3s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  shadedclient  |  38m 22s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 29s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  shellcheck  |   0m  1s |  |  No new issues.  |
   | +1 :green_heart: |  shadedclient  |  36m 40s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 33s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 112m 31s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6448/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/6448 |
   | Optional Tests | dupname asflicense codespell detsecrets shellcheck 
shelldocs |
   | uname | Linux f57beaab6d95 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 
15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / e8632c480e9d487b88dc93828eef28cd44977dfc |
   | Max. process+thread count | 540 (vs. ulimit of 5500) |
   | modules | C:  U:  |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6448/1/console |
   | versions | git=2.25.1 maven=3.6.3 shellcheck=0.7.0 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Improve create-release RUN script
> ---------------------------------
>
>                 Key: HADOOP-19038
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19038
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.4.0, 3.5.0
>            Reporter: Shilun Fan
>            Assignee: Shilun Fan
>            Priority: Major
>              Labels: pull-request-available
>
> Using create-release will create a docker image locally, but three of the RUN 
> scripts may fail to execute.
> 1. RUN groupadd --non-unique -g 0 root
> {code:java}
> => ERROR [16/20] RUN groupadd --non-unique -g 0 root                          
>                                   0.2s
> ------
>  > [16/20] RUN groupadd --non-unique -g 0 root:
> 0.154 groupadd: group 'root' already exists
> ------
> Dockerfile:100
> --------------------
>   98 |
>   99 |     LABEL org.apache.hadoop.create-release="cr-19697"
>  100 | >>> RUN groupadd --non-unique -g 0 root
>  101 |     RUN useradd -g 0 -u 0 -m root
>  102 |     RUN chown -R root /home/root
> {code}
> 2. RUN useradd -g 0 -u 0 -m root
> {code:java}
>  > [17/20] RUN useradd -g 0 -u 0 -m root:
> 0.165 useradd: user 'root' already exists
> ------
> Dockerfile:101
> --------------------
>   99 |     LABEL org.apache.hadoop.create-release="cr-12068"
>  100 |     RUN groupadd --non-unique -g 0 root; exit 0;
>  101 | >>> RUN useradd -g 0 -u 0 -m root
>  102 |     RUN chown -R root /home/root
>  103 |     ENV HOME /home/root
> {code}
> 3. RUN chown -R root /home/root
> {code:java}
>  > [18/20] RUN chown -R root /home/root:
> 0.168 chown: cannot access '/home/root': No such file or directory
> ------
> Dockerfile:102
> --------------------
>  100 |     RUN groupadd --non-unique -g 0 root; exit 0;
>  101 |     RUN useradd -g 0 -u 0 -m root; exit 0;
>  102 | >>> RUN chown -R root /home/root
>  103 |     ENV HOME /home/root
>  104 |     RUN mkdir -p /maven
> --------------------
> {code}
> Even if these three scripts fail, subsequent steps can continue to be 
> executed, so I added exit 0 after the script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to