[ 
https://issues.apache.org/jira/browse/HADOOP-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250165#comment-13250165
 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-8248:
------------------------------------------------

> ... But on Hadoop a +1 from a committer who is not the patch author has 
> always been required for significant patches.

Good to know that.  I did not see anyone committing significant patches without 
a +1 from another committer in the past, except when the patch was a join work 
of multiple committers, but I did not know that it was a requirement.

We should also clarify the following:
- For a join work of multiple committers, all of the authors cannot review the 
patch for significant patches.
- For merging from a branch, the three +1's cannot be cast from any of the 
committers who worked on the branch.

Does it make sense?  I will post proposed change.
                
> Clarify bylaws about review-then-commit policy
> ----------------------------------------------
>
>                 Key: HADOOP-8248
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8248
>             Project: Hadoop Common
>          Issue Type: Task
>            Reporter: Todd Lipcon
>         Attachments: proposed-bylaw-change.txt
>
>
> As discussed on the mailing list (thread "Requirements for patch review" 
> 4/4/2012) we should clarify the bylaws with respect to the review-then-commit 
> policy. This JIRA is to agree on the proposed change.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to