[
https://issues.apache.org/jira/browse/HADOOP-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250176#comment-13250176
]
Todd Lipcon commented on HADOOP-8248:
-------------------------------------
bq. For a join work of multiple committers, all of the authors cannot review
the patch for significant patches.
My thinking here is that it's fine if one committer does some minor fixup or
adds test cases to a patch that another authored. For example, if I start a
patch, but don't get time to finish the unit tests, and you help out by adding
a test, I think it's OK for you to commit it assuming I +1 your addition. Put
another way, any given "chunk" of the patch should be reviewed by a committer
who didn't write it.
I don't want to get too pedantic about it, though -- IMO it's the spirit that's
important. Code reviews are important for spotting mistakes, and it's hard to
spot your own mistakes. So any piece of code should be +1ed at by an expert (ie
committer) who didn't write that bit of code.
bq. For merging from a branch, the three +1's cannot be cast from any of the
committers who worked on the branch.
I disagree on this -- my assumption is that all of the patches on the branch
have been reviewed according to the above policy, so everything's been looked
at by someone who didn't write it. In my mind, the +1s on the merge are
basically a commitment to stand by the work to be merged and an assertion that
you think it is good code, a good feature, etc. If the development on the
branch looks shoddy/sketchy/whatever, then there's plenty of opportunity for
other committers to -1 it.
Perhaps we should add a 3-day minimum voting period for branch merges to trunk
when that branch didn't follow the normal RTC guidelines?
> Clarify bylaws about review-then-commit policy
> ----------------------------------------------
>
> Key: HADOOP-8248
> URL: https://issues.apache.org/jira/browse/HADOOP-8248
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Todd Lipcon
> Attachments: c8248_20120409.patch, proposed-bylaw-change.txt
>
>
> As discussed on the mailing list (thread "Requirements for patch review"
> 4/4/2012) we should clarify the bylaws with respect to the review-then-commit
> policy. This JIRA is to agree on the proposed change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
