zhangbutao commented on PR #7106: URL: https://github.com/apache/hadoop/pull/7106#issuecomment-2404903130
> while this change seems valid, why aren't you just using `Shell.setEnvironment()` getting at the patch either through reflection or (cleaner) putting some accessor class inside the same package? @steveloughran Thanks your suggestion. Not sure if I understand what you mean correctly. Hive does not use the `Shell` directly. The error stacktrace in HADOOP-19305 shows that it is called indirectly by Hive through `RawLocalFileSystem` : `org.apache.hadoop.fs.RawLocalFileSystem$DeprecatedRawLocalFileStatus.getPermission(RawLocalFileSystem.java:952) ~[hadoop-common-3.4.0.jar:?]` So i don't think it is good to use `Shell.setEnvironment()`. BTW, the root cause is not from `Shell.java`, but this change can as a workaroud to skip the exception in Hive. It would be good if we can merge this as a improvement. I am also trying to fix it at the root & Hive side. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
