zhangbutao commented on PR #7106: URL: https://github.com/apache/hadoop/pull/7106#issuecomment-2405192509
> @zhangbutao afraid RC3 is already out, and as this is a test only failure I don't think it is a blocker. @steveloughran No worry, i can also fix this at Hive side. See https://github.com/apache/hive/pull/5500/commits/fa7797b8988a83288f53b073987ce586344fdecf . In fact, This related code snippet is useless & incorrect, but it triggered this issue. I just remove the code snippet. I think i won't take much time to fix the useless test code. > Why doesn't the setEnvironment method work for your tests? Sorry i didn't get you about the setEnvironment. Do you mean the change like this: ``` index 91868365b13..8f2387ebaa3 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java @@ -977,7 +977,7 @@ private void runCommand() throws IOException { builder.environment().clear(); } - builder.environment().putAll(this.environment); + setEnvironment(environment); ``` I tested this `setEnvironment(environment)`, it can also fix my issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
