slfan1989 commented on code in PR #7106:
URL: https://github.com/apache/hadoop/pull/7106#discussion_r1796365480
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:
##########
@@ -977,7 +977,9 @@ private void runCommand() throws IOException {
builder.environment().clear();
}
- builder.environment().putAll(this.environment);
+ if (!environment.isEmpty()) {
Review Comment:
@zhangbutao Personally, I think adding a check is reasonable, but can we
modify it further based on Steve's suggestions?
cc: @steveloughran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
